Issue 866653002: Don't try to GetPixelsForTesting if not testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 866653002: Don't try to GetPixelsForTesting if not testing (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	sky/viewer/internals.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

jamesr

lgtm, but do we even want to expose this object when we aren't in testing ...

5 years, 11 months ago (2015-01-22 02:25:01 UTC) #2

abarth-chromium

On 2015/01/22 at 02:25:01, jamesr wrote: > lgtm, but do we even want to expose ...

5 years, 11 months ago (2015-01-22 02:26:03 UTC) #3

abarth-chromium

5 years, 11 months ago (2015-01-22 02:26:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f0d9f93338f050706810025f7f711201131484b (presubmit successful).