Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 866643002: Revert of Revert of Eliminate components_unittests' dependence on chrome resources. (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Eliminate components_unittests' dependence on chrome resources. (patchset #1 id:1 of https://codereview.chromium.org/867473002/) Reason for revert: i'll disable the test on asan. reverting this will break other things. Original issue's description: > Revert of Eliminate components_unittests' dependence on chrome resources. (patchset #8 id:180001 of https://codereview.chromium.org/856163002/) > > Reason for revert: > Causes Mac ASAN bot to fail on BookmarkModelTest.Sort. The failures look the same as those referenced in crbug.com/450464. > > https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/6320 > > Original issue's description: > > Eliminate components_unittests' dependence on chrome resources. > > > > This CL changes components_unittests to create its own pakfile rather than > > relying on the chrome pakfile. To do this it adds a repack step that repacks > > the pakfiles that components_unittests needs into a > > components_unittests_resources.pak file, and then loads that pakfile > > explicitly. > > > > This change means that components_unittests now passes after a clean build, > > whereas before it would fail due to missing resources. > > > > This is based on blundell's change: https://codereview.chromium.org/258043003/ > > > > BUG=348563, 450464 > > R=blundell@chromium.org, thakis@chromium.org > > > > Committed: https://chromium.googlesource.com/chromium/src/+/045c9bf1d36f35643a077891dedf24054f2032a3 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/e98e8e7654b7e51f98e92514897f8e1284eaa571 > > TBR=blundell@chromium.org,thakis@chromium.org,maruel@chromium.org,jam@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=348563, 450464 > > Committed: https://crrev.com/a2e3cc7a3586e7a27b414c47ae4db3d10efe40ba > Cr-Commit-Position: refs/heads/master@{#312490} TBR=blundell@chromium.org,thakis@chromium.org,maruel@chromium.org,chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=348563, 450464 Committed: https://crrev.com/6bb3c8f170c0f59873ba2ce1a13e0be7a380da46 Cr-Commit-Position: refs/heads/master@{#312507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -53 lines) Patch
M components/bookmarks/browser/bookmark_model_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 5 chunks +22 lines, -5 lines 0 comments Download
M components/components_unittests.isolate View 3 chunks +1 line, -10 lines 0 comments Download
M components/test/run_all_unittests.cc View 4 chunks +6 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Revert of Eliminate components_unittests' dependence on chrome resources.
5 years, 11 months ago (2015-01-22 00:40:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866643002/1
5 years, 11 months ago (2015-01-22 00:42:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 00:44:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6bb3c8f170c0f59873ba2ce1a13e0be7a380da46 Cr-Commit-Position: refs/heads/master@{#312507}
5 years, 11 months ago (2015-01-22 00:47:00 UTC) #4
M-A Ruel
5 years, 11 months ago (2015-01-22 00:47:30 UTC) #5
Message was sent while issue was closed.
trololo lgtm

Powered by Google App Engine
This is Rietveld 408576698