Fix glGetQueryObjectiv call on devices which expect EXT variants.

gpu/command_buffer/service/gpu_tracer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gpu_tracer.h"
 
 #include <deque>
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
@@ skipping 126 matching lines @@
 
     case kTracerTypeDisjointTimer:
       // For the disjoint timer, GPU idle time does not seem to increment the
       // internal counter. We must calculate the offset before any query. The
       // good news is any device that supports disjoint timer will also support
       // glGetInteger64v, so we can query it directly unlike the ARBTimer case.
       // The "offset_" variable will always be 0 during normal use cases, only
       // under the unit tests will it be set to specific test values.
       if (offset_ == 0) {
         GLint64 gl_now = 0;
         glGetInteger64v(GL_TIMESTAMP, &gl_now);

[no sievers, 2015/01/21 23:31:15]

Am talking about this call site.

         offset_ = cpu_time_->GetCurrentTime() -
                   gl_now / base::Time::kNanosecondsPerMicrosecond;
       }
       // Intentionally fall through to kTracerTypeARBTimer case.xs
     case kTracerTypeARBTimer:
       // GL_TIMESTAMP and GL_TIMESTAMP_EXT both have the same value.
       glQueryCounter(queries_[0], GL_TIMESTAMP);
       break;
   }
 }
@@ skipping 15 matching lines @@
     outputter_->TraceServiceEnd(category_, name_);
   }
 }
 
 bool GPUTrace::IsAvailable() {
   if (tracer_type_ != kTracerTypeInvalid) {
     if (!end_requested_)
       return false;
 
     GLint done = 0;
-    glGetQueryObjectiv(queries_[1], GL_QUERY_RESULT_AVAILABLE, &done);
+    glGetQueryObjectivARB(queries_[1], GL_QUERY_RESULT_AVAILABLE, &done);

[no sievers, 2015/01/21 23:24:45]

So ignoring everything we do in other places (like the decoder), I think the
current code is correct: For GL_ARB_timer_query at least which is written
against desktop GL 3.2, which will have this entry point.
For GLES, it should however be GetQueryObjectivEXT().

     return !!done;
   }
 
   return true;
 }
 
 void GPUTrace::Process() {
   if (tracer_type_ == kTracerTypeInvalid)
     return;
 
@@ skipping 287 matching lines @@
 void GPUTracer::IssueProcessTask() {
   if (traces_.empty() || process_posted_)
     return;
 
   process_posted_ = true;
   PostTask();
 }
 
 }  // namespace gles2
 }  // namespace gpu