net/base/mime_util.cc - Issue 866573004: media: Enable Opus support in Clank <video> and MSE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/mime_util.cc

Issue 866573004: media: Enable Opus support in Clank <video> and MSE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit fixes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/mime_util.cc

diff --git a/net/base/mime_util.cc b/net/base/mime_util.cc

index d1b67d580e2713c8a7baf16d3d432bda18001f12..0ae8398eb498c985d5ce742f6639994145134cc0 100644

--- a/net/base/mime_util.cc

+++ b/net/base/mime_util.cc

@@ -475,9 +475,8 @@ static bool IsCodecSupportedOnAndroid(MimeUtil::Codec codec) {

return base::android::BuildInfo::GetInstance()->sdk_int() >= 19;

case MimeUtil::OPUS:

- // TODO(vigneshv): Change this similar to the VP9 check once Opus is

- // supported on Android (http://crbug.com/318436).

- return false;

+ // Opus is supported only in Lollipop+ (API Level 21).

+ return base::android::BuildInfo::GetInstance()->sdk_int() >= 21;

case MimeUtil::THEORA:

return false;