Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: media/base/android/media_codec_bridge_unittest.cc

Issue 866573004: media: Enable Opus support in Clank <video> and MSE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_bridge_unittest.cc
diff --git a/media/base/android/media_codec_bridge_unittest.cc b/media/base/android/media_codec_bridge_unittest.cc
index 960e33e319c609ad12ec030b3ba015b2c1d1e073..ca758f2a90ecfae5955ef6757e1272183d779317 100644
--- a/media/base/android/media_codec_bridge_unittest.cc
+++ b/media/base/android/media_codec_bridge_unittest.cc
@@ -160,7 +160,8 @@ TEST(MediaCodecBridgeTest, DoNormal) {
scoped_ptr<media::AudioCodecBridge> media_codec;
media_codec.reset(AudioCodecBridge::Create(kCodecMP3));
- ASSERT_TRUE(media_codec->Start(kCodecMP3, 44100, 2, NULL, 0, false, NULL));
+ ASSERT_TRUE(media_codec->Start(
+ kCodecMP3, 44100, 2, NULL, 0, 0, 0, false, NULL));
int input_buf_index = -1;
MediaCodecStatus status =
@@ -229,12 +230,13 @@ TEST(MediaCodecBridgeTest, InvalidVorbisHeader) {
uint8 invalid_first_byte[] = { 0x00, 0xff, 0xff, 0xff, 0xff };
EXPECT_FALSE(media_codec->Start(
kCodecVorbis, 44100, 2, invalid_first_byte, sizeof(invalid_first_byte),
- false, NULL));
+ 0, 0, false, NULL));
// Size of the header does not match with the data we passed in.
uint8 invalid_size[] = { 0x02, 0x01, 0xff, 0x01, 0xff };
EXPECT_FALSE(media_codec->Start(
- kCodecVorbis, 44100, 2, invalid_size, sizeof(invalid_size), false, NULL));
+ kCodecVorbis, 44100, 2, invalid_size, sizeof(invalid_size),
+ 0, 0, false, NULL));
// Size of the header is too large.
size_t large_size = 8 * 1024 * 1024 + 2;
@@ -244,10 +246,29 @@ TEST(MediaCodecBridgeTest, InvalidVorbisHeader) {
very_large_header[i] = 0xff;
very_large_header[large_size - 1] = 0xfe;
EXPECT_FALSE(media_codec->Start(
- kCodecVorbis, 44100, 2, very_large_header, 0x80000000, false, NULL));
+ kCodecVorbis, 44100, 2, very_large_header, 0x80000000,
+ 0, 0, false, NULL));
delete[] very_large_header;
}
+TEST(MediaCodecBridgeTest, InvalidOpusHeader) {
+ SKIP_TEST_IF_MEDIA_CODEC_BRIDGE_IS_NOT_AVAILABLE();
+
+ scoped_ptr<media::AudioCodecBridge> media_codec;
+ media_codec.reset(AudioCodecBridge::Create(kCodecOpus));
+ uint8 dummy_extra_data[] = { 0x00, 0x00 };
+
+ // Codec Delay is < 0.
+ EXPECT_FALSE(media_codec->Start(
+ kCodecOpus, 48000, 2, dummy_extra_data, sizeof(dummy_extra_data),
+ -1, 0, false, NULL));
+
+ // Seek Preroll is < 0.
+ EXPECT_FALSE(media_codec->Start(
+ kCodecOpus, 48000, 2, dummy_extra_data, sizeof(dummy_extra_data),
+ 0, -1, false, NULL));
+}
+
TEST(MediaCodecBridgeTest, PresentationTimestampsDoNotDecrease) {
SKIP_TEST_IF_MEDIA_CODEC_BRIDGE_IS_NOT_AVAILABLE();

Powered by Google App Engine
This is Rietveld 408576698