Add builder_type to fetch builds for android-chrome.

Add builder_type to fetch builds for android-chrome.
BUG=
NOTRY=True

Committed: https://crrev.com/d04be4fda0224a42f24a0e1132c057c4da2fa833
Cr-Commit-Position: refs/heads/master@{#313127}

[prasadv, 2015-01-21 23:08:26]

prasadv@chromium.org changed reviewers:
+ qyearsley@chromium.org, robertocn@chromium.org

[RobertoCN, 2015-01-21 23:15:19]

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
File tools/auto_bisect/fetch_build.py (right):

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
tools/auto_bisect/fetch_build.py:80: extra_src =
bisect_utils.LoadExtraSrc(extra_src)
I think it would be more readable if we used an additional name here:
(Note that I have no idea what LoadExtraSrc does)

loaded_extra_src = bisect_utils.LoadExtraSrc(extra_src)
return AndroidChromeBuildArchive(
    target_arch, target_platform, loaded_extra_src)

[prasadv, 2015-01-23 18:05:57]

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
File tools/auto_bisect/fetch_build.py (right):

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
tools/auto_bisect/fetch_build.py:80: extra_src =
bisect_utils.LoadExtraSrc(extra_src)
On 2015/01/21 23:15:19, robertocn wrote:
> I think it would be more readable if we used an additional name here:
> (Note that I have no idea what LoadExtraSrc does)
> 
> loaded_extra_src = bisect_utils.LoadExtraSrc(extra_src)
> return AndroidChromeBuildArchive(
>     target_arch, target_platform, loaded_extra_src)

Done.

[qyearsley, 2015-01-26 17:50:32]

LGTM

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
File tools/auto_bisect/fetch_build.py (right):

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
tools/auto_bisect/fetch_build.py:84: raise RuntimeError('Invalid or missing
--extra_src.')
[Optional] In the case of a failure, it may be useful to also include the value
of extra_src passed in, and maybe the error that was raised.

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
tools/auto_bisect/fetch_build.py:204: class
AndroidChromeBuildArchive(BuildArchive):
[Optional] It can be seen from the code below, but you could also explicitly say
here what needs to be in the extra source module that is imported, e.g.:

If AndroidChromeBuildArchive is used, it is assumed that the --extra_src is a
valid Python module which contains the module-level functions GetBucketName and
GetArchiveDirectory.

You can also note that this is necessary because this code could include 
internal-only names.

[prasadv, 2015-01-26 18:58:26]

PTAL for final pass.

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
File tools/auto_bisect/fetch_build.py (right):

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
tools/auto_bisect/fetch_build.py:84: raise RuntimeError('Invalid or missing
--extra_src.')
On 2015/01/26 17:50:32, qyearsley wrote:
> [Optional] In the case of a failure, it may be useful to also include the
value
> of extra_src passed in, and maybe the error that was raised.

Done.

https://codereview.chromium.org/866573003/diff/20001/tools/auto_bisect/fetch_...
tools/auto_bisect/fetch_build.py:204: class
AndroidChromeBuildArchive(BuildArchive):
On 2015/01/26 17:50:32, qyearsley wrote:
> [Optional] It can be seen from the code below, but you could also explicitly
say
> here what needs to be in the extra source module that is imported, e.g.:
> 
> If AndroidChromeBuildArchive is used, it is assumed that the --extra_src is a
> valid Python module which contains the module-level functions GetBucketName
and
> GetArchiveDirectory.
> 
> You can also note that this is necessary because this code could include 
> internal-only names.

Done.

[qyearsley, 2015-01-26 20:42:55]

LGTM, should be good to submit now.

[prasadv, 2015-01-26 20:44:51]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2015-01-26 20:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/866573003/60001

[commit-bot: I haz the power, 2015-01-26 20:46:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-26 20:47:38]

Patchset 4 (id:??) landed as
https://crrev.com/d04be4fda0224a42f24a0e1132c057c4da2fa833
Cr-Commit-Position: refs/heads/master@{#313127}