src/effects/SkGpuBlurUtils.cpp - Issue 866573002: XPFactory lazily initializie in drawstate / GrPaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkGpuBlurUtils.cpp

Issue 866573002: XPFactory lazily initializie in drawstate / GrPaint (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: cleanup Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkGpuBlurUtils.cpp

diff --git a/src/effects/SkGpuBlurUtils.cpp b/src/effects/SkGpuBlurUtils.cpp

index 8603120e86498a3163b9abe964a243b84d4ed82a..758c4224a95ac78792b8924a7bba63ce15d7d8a4 100644

--- a/src/effects/SkGpuBlurUtils.cpp

+++ b/src/effects/SkGpuBlurUtils.cpp

@@ -53,7 +53,6 @@ static void convolve_gaussian_1d(GrContext* context,

bool useBounds,

float bounds[2]) {

GrPaint paint;

- paint.reset();

SkAutoTUnref<GrFragmentProcessor> conv(GrConvolutionEffect::CreateGaussian(

texture, direction, radius, sigma, useBounds, bounds));

paint.addColorProcessor(conv);

@@ -73,7 +72,6 @@ static void convolve_gaussian_2d(GrContext* context,

SkISize size = SkISize::Make(2 * radiusX + 1, 2 * radiusY + 1);

SkIPoint kernelOffset = SkIPoint::Make(radiusX, radiusY);

GrPaint paint;

- paint.reset();

SkAutoTUnref<GrFragmentProcessor> conv(GrMatrixConvolutionEffect::CreateGaussian(

texture, bounds, size, 1.0, 0.0, kernelOffset,

useBounds ? GrTextureDomain::kClamp_Mode : GrTextureDomain::kIgnore_Mode,

« no previous file with comments | « include/gpu/GrPaint.h ('k') | src/gpu/GrContext.cpp » ('j') | no next file with comments »