Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 866553004: components: Remove grit_out_dir variable from components_tests.gyp (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Remove grit_out_dir variable from components_tests.gyp It should not be necessary to declare this variable at the top of this gyp file. If it is necessary to declare this variable, this is not the place to declare it anyway (which also looks pretty random). BUG=None TEST=components_unittests R=blundell@chromium.org Committed: https://crrev.com/3c4788d375b7c327d2ca865ec845e803e727b73a Cr-Commit-Position: refs/heads/master@{#315285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 10 months ago (2015-02-05 17:27:19 UTC) #1
blundell
lgtm
5 years, 10 months ago (2015-02-06 08:07:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866553004/1
5 years, 10 months ago (2015-02-09 13:09:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 13:18:11 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 13:18:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c4788d375b7c327d2ca865ec845e803e727b73a
Cr-Commit-Position: refs/heads/master@{#315285}

Powered by Google App Engine
This is Rietveld 408576698