Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 866553003: Allocate typed array for rempio2 result. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allocate typed array for rempio2 result. R=svenpanne@chromium.org BUG=chromium:451670 LOG=N Committed: https://crrev.com/a44511d4131c74c6a0f9622af9ccaab83a5235bc Cr-Commit-Position: refs/heads/master@{#26482}

Patch Set 1 #

Patch Set 2 : fix leak #

Patch Set 3 : make runtime call slightly faster. #

Total comments: 3

Patch Set 4 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -62 lines) Patch
M src/bootstrapper.cc View 1 3 chunks +57 lines, -40 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 2 3 1 chunk +8 lines, -12 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 10 months ago (2015-02-05 15:20:53 UTC) #1
Sven Panne
LGTM with nits. https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc File src/runtime/runtime-maths.cc (right): https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc#newcode70 src/runtime/runtime-maths.cc:70: double* y = reinterpret_cast<double*>(backing_store); A static_cast ...
5 years, 10 months ago (2015-02-06 07:37:28 UTC) #2
Yang
On 2015/02/06 07:37:28, Sven Panne wrote: > LGTM with nits. > > https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc > File ...
5 years, 10 months ago (2015-02-06 09:31:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866553003/60001
5 years, 10 months ago (2015-02-06 09:32:33 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-06 09:55:03 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 09:55:18 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a44511d4131c74c6a0f9622af9ccaab83a5235bc
Cr-Commit-Position: refs/heads/master@{#26482}

Powered by Google App Engine
This is Rietveld 408576698