Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 866533004: Add tests for resizing VPX larger than initial size (Closed)

Created:
5 years, 11 months ago by Wez
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for resizing VPX larger than initial size. libvpx/VP8 currently allows resizing upward but will crash on codec teardown in that case; these tests ensure we don't regress when we remove the workarounds in VideoEncoderVpx. BUG=134202 Committed: https://crrev.com/ae4b5eecd062dc4d28356b9925752ca52f53c46c Cr-Commit-Position: refs/heads/master@{#313741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M remoting/codec/video_encoder_vpx_unittest.cc View 6 chunks +28 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Wez
PTAL
5 years, 11 months ago (2015-01-27 21:28:51 UTC) #2
Sergey Ulanov
lgtm
5 years, 11 months ago (2015-01-28 06:54:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866533004/1
5 years, 10 months ago (2015-01-29 18:24:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 18:32:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:33:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae4b5eecd062dc4d28356b9925752ca52f53c46c
Cr-Commit-Position: refs/heads/master@{#313741}

Powered by Google App Engine
This is Rietveld 408576698