Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 866533003: Use FunctionLiteral for class constructor (Closed)

Created:
5 years, 11 months ago by arv (Not doing code reviews)
Modified:
5 years, 11 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use FunctionLiteral for class constructor Motivation: Code cleanup BUG=None LOG=N R=adamk Committed: https://crrev.com/c883aed7d62e62b36c522924119ab678ac41edfa Cr-Commit-Position: refs/heads/master@{#26210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/ast.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 11 months ago (2015-01-21 22:51:10 UTC) #1
adamk
lgtm
5 years, 11 months ago (2015-01-21 22:54:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866533003/1
5 years, 11 months ago (2015-01-21 23:06:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 06:17:15 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 06:17:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c883aed7d62e62b36c522924119ab678ac41edfa
Cr-Commit-Position: refs/heads/master@{#26210}

Powered by Google App Engine
This is Rietveld 408576698