chrome/browser/ui/autofill/chrome_autofill_client.cc - Issue 866523002: [Abandoned] Add Autofill to the <webview> chrome://chrome-signin page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 866523002: [Abandoned] Add Autofill to the <webview> chrome://chrome-signin page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add dcheck for the chrome signin page Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('K') | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/chrome_autofill_client.cc

diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc

index 37c8c48ec95f0cb0bda949838cf64c5b8f4254a0..52cd2fa027ae6e285357508b4a601a2c9b2f862c 100644

--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc

+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc

@@ -186,13 +186,13 @@ void ChromeAutofillClient::ShowAutofillPopup(

element_bounds + client_area.OffsetFromOrigin();

// Will delete or reuse the old |popup_controller_|.

- popup_controller_ =

- AutofillPopupControllerImpl::GetOrCreate(popup_controller_,

- delegate,

- web_contents(),

- web_contents()->GetNativeView(),

- element_bounds_in_screen_space,

- text_direction);

+ popup_controller_ = AutofillPopupControllerImpl::GetOrCreate(

+ popup_controller_,

+ delegate,

+ web_contents(),

+ web_contents()->GetContentNativeView(),

+ element_bounds_in_screen_space,

+ text_direction);

popup_controller_->Show(suggestions);

}