[Abandoned] Add Autofill to the <webview> chrome://chrome-signin page

chrome/browser/ui/autofill/chrome_autofill_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
 
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 22 matching lines @@
 #include "ui/gfx/geometry/rect.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/android/chromium_application.h"
 #include "chrome/browser/ui/android/autofill/autofill_logger_android.h"
 #else
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "components/ui/zoom/zoom_controller.h"
 #endif
 
+#if defined(ENABLE_EXTENSIONS)
+#include "extensions/browser/guest_view/web_view/web_view_guest.h"
+#endif
+
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(autofill::ChromeAutofillClient);
 
 namespace autofill {
 
 ChromeAutofillClient::ChromeAutofillClient(content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       unmask_controller_(web_contents),
       last_rfh_to_rac_(nullptr) {
   DCHECK(web_contents);
 
@@ skipping 125 matching lines @@
 void ChromeAutofillClient::ShowAutofillPopup(
     const gfx::RectF& element_bounds,
     base::i18n::TextDirection text_direction,
     const std::vector<autofill::Suggestion>& suggestions,
     base::WeakPtr<AutofillPopupDelegate> delegate) {
   // Convert element_bounds to be in screen space.
   gfx::Rect client_area = web_contents()->GetContainerBounds();
   gfx::RectF element_bounds_in_screen_space =
       element_bounds + client_area.OffsetFromOrigin();
 
+  gfx::NativeView container_view = web_contents()->GetNativeView();
+  // If the WebContents is inside a <webview>, use the embedder's native view,
+  // since the <webview> does not have its own native view.
+#if defined(ENABLE_EXTENSIONS)
+  if (extensions::WebViewGuest::FromWebContents(web_contents()))
+    container_view = web_contents()->GetContentNativeView();
+#endif
+
   // Will delete or reuse the old |popup_controller_|.
   popup_controller_ =
       AutofillPopupControllerImpl::GetOrCreate(popup_controller_,
                                                delegate,
                                                web_contents(),
-                                               web_contents()->GetNativeView(),

[Evan Stade, 2015/02/05 03:12:56]

when I look at what this view is actually used for, it seems like
GetContentNativeView() should be fine (I can only see it being used for
gfx::Screen::GetScreenFor()). You can just go ahead and change to
GetContentNativeView(), provided you do a 2-second sanity check of normal web
autofill on mac and non-mac.

[noms (inactive), 2015/02/05 18:56:08]

Done. I've tested it on all desktop platforms, and it looks good!

+                                               container_view,
                                                element_bounds_in_screen_space,
                                                text_direction);
 
   popup_controller_->Show(suggestions);
 }
 
 void ChromeAutofillClient::UpdateAutofillPopupDataListValues(
     const std::vector<base::string16>& values,
     const std::vector<base::string16>& labels) {
   if (popup_controller_.get())
@@ skipping 79 matching lines @@
       new AutofillMsg_FirstUserGestureObservedInTab(routing_id()));
 }
 
 void ChromeAutofillClient::LinkClicked(const GURL& url,
                                        WindowOpenDisposition disposition) {
   web_contents()->OpenURL(content::OpenURLParams(
       url, content::Referrer(), disposition, ui::PAGE_TRANSITION_LINK, false));
 }
 
 }  // namespace autofill