Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 866493003: Retry "Use a WeakCell in the CallIC type vector." (Closed)

Created:
5 years, 10 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Retry "Use a WeakCell in the CallIC type vector." The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. R=ulan@chromium.org Committed: https://crrev.com/6fc97a19653e03a891d3cd397069d5a10b9ab325 Cr-Commit-Position: refs/heads/master@{#26420}

Patch Set 1 #

Patch Set 2 : Allow both unconditional and gc-policy vector IC clearing. #

Patch Set 3 : REBASE. #

Patch Set 4 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -102 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 chunks +33 lines, -9 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 chunks +32 lines, -14 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +17 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 2 chunks +34 lines, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 4 chunks +33 lines, -11 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/type-feedback-vector.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 1 2 5 chunks +20 lines, -23 lines 0 comments Download
M src/type-info.cc View 1 chunk +12 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 4 chunks +36 lines, -11 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +13 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mvstanton
Hi Ulan, Here is another run at the WeakCell work. The "new" work is in ...
5 years, 10 months ago (2015-02-02 09:16:50 UTC) #2
ulan
diff between PS2 and PS2 lgtm.
5 years, 10 months ago (2015-02-02 09:41:39 UTC) #3
ulan
On 2015/02/02 09:41:39, ulan wrote: > diff between PS2 and PS2 lgtm. diff between PS2 ...
5 years, 10 months ago (2015-02-02 09:42:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866493003/60001
5 years, 10 months ago (2015-02-04 08:44:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866493003/80001
5 years, 10 months ago (2015-02-04 09:44:36 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-04 09:46:16 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 09:46:36 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6fc97a19653e03a891d3cd397069d5a10b9ab325
Cr-Commit-Position: refs/heads/master@{#26420}

Powered by Google App Engine
This is Rietveld 408576698