Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 866473005: Make it possible to bisect builds of Chrome for ChromeOS (Closed)

Created:
5 years, 11 months ago by dmazzoni
Modified:
5 years, 11 months ago
CC:
chromium-reviews, David Tseng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make it possible to bisect builds of Chrome for ChromeOS BUG=78158, 177335 Committed: https://crrev.com/76e907d6bb83cbd5ccb35accc93cc9e5c0db07c3 Cr-Commit-Position: refs/heads/master@{#312586}

Patch Set 1 #

Patch Set 2 : Get rid of missing chromeos build comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M tools/bisect-builds.py View 1 5 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dmazzoni
At first glance the only reason we can't bisect Chrome for Chrome OS is that ...
5 years, 11 months ago (2015-01-21 22:08:50 UTC) #2
James Cook
I enthusiastically support this change but have no idea what's going on with icudtl.dat. +mukai ...
5 years, 11 months ago (2015-01-21 23:21:31 UTC) #3
Jun Mukai
On 2015/01/21 23:21:31, James Cook wrote: > I enthusiastically support this change but have no ...
5 years, 11 months ago (2015-01-22 00:26:33 UTC) #4
James Cook
Oh, LGTM too
5 years, 11 months ago (2015-01-22 00:29:49 UTC) #5
dmazzoni
Sounds good, I'll land it like this and we can see how well it works ...
5 years, 11 months ago (2015-01-22 07:17:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866473005/20001
5 years, 11 months ago (2015-01-22 07:17:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 08:15:16 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 08:16:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76e907d6bb83cbd5ccb35accc93cc9e5c0db07c3
Cr-Commit-Position: refs/heads/master@{#312586}

Powered by Google App Engine
This is Rietveld 408576698