content/browser/web_contents/web_contents_view_aura_browsertest.cc - Issue 866443003: Push API: Don't require notification if tab is visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 866443003: Push API: Don't require notification if tab is visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ycm_outdir

Patch Set: Expose WebContents::IsHiddenIgnoringCapturing instead of PushMessagingService::IsWebContentsUserVis… Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/push_messaging_service_impl.cc ('K') | « content/browser/web_contents/web_contents_view_aura.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

index 6e8480c68ef4142487a527ebb1ab5982616b882e..53d7e50dec1c5115912fd8c60ba7243bf662d32f 100644

--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc

+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

@@ -883,11 +883,11 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, HideContentOnParenHide) {

WebContentsImpl* web_contents =

static_cast<WebContentsImpl*>(shell()->web_contents());

aura::Window* content = web_contents->GetNativeView()->parent();

- EXPECT_TRUE(web_contents->should_normally_be_visible());

+ EXPECT_TRUE(web_contents->IsHiddenIgnoringCapturing());

content->Hide();

- EXPECT_FALSE(web_contents->should_normally_be_visible());

+ EXPECT_FALSE(web_contents->IsHiddenIgnoringCapturing());

content->Show();

- EXPECT_TRUE(web_contents->should_normally_be_visible());

+ EXPECT_TRUE(web_contents->IsHiddenIgnoringCapturing());

}

// Ensure that SnapToPhysicalPixelBoundary() is called on WebContentsView parent