content/browser/web_contents/web_contents_impl.h - Issue 866443003: Push API: Don't require notification if tab is visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 866443003: Push API: Don't require notification if tab is visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ycm_outdir

Patch Set: Expose WebContents::IsHiddenIgnoringCapturing instead of PushMessagingService::IsWebContentsUserVis… Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/push_messaging_service_impl.cc ('K') | « chrome/browser/ui/android/tab_model/tab_model.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 0f56ad43aae40943a046046fdf34f6b9341d1974..6b915033cdfb1e9ffc4d9c59924e0069cdd35f08 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -180,8 +180,6 @@ class CONTENT_EXPORT WebContentsImpl

return screen_orientation_dispatcher_host_.get();

}

- bool should_normally_be_visible() { return should_normally_be_visible_; }

// Indicate if the window has been occluded, and pass this to the views, only

// if there is no active capture going on (otherwise it is dropped on the

// floor).

@@ -262,6 +260,7 @@ class CONTENT_EXPORT WebContentsImpl

bool IsBeingDestroyed() const override;

void NotifyNavigationStateChanged(InvalidateTypes changed_flags) override;

base::TimeTicks GetLastActiveTime() const override;

+ bool IsHiddenIgnoringCapturing() const override;

void WasShown() override;

void WasHidden() override;

bool NeedToFireBeforeUnload() override;