Push API: Don't require notification if tab is visible.

chrome/browser/services/gcm/push_messaging_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/push_messaging_service_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 14 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/content_settings/core/common/permission_request_id.h"
 #include "components/gcm_driver/gcm_driver.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/platform_notification_data.h"
+#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/l10n/l10n_util.h"
 
+#if defined(OS_ANDROID)
+#include "chrome/browser/ui/android/tab_model/tab_model.h"
+#include "chrome/browser/ui/android/tab_model/tab_model_list.h"
+#else
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_iterator.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#endif
+
 namespace gcm {
 
 namespace {
 const int kMaxRegistrations = 1000000;
 
 blink::WebPushPermissionStatus ToPushPermission(ContentSetting setting) {
   switch (setting) {
     case CONTENT_SETTING_ALLOW:
       return blink::WebPushPermissionStatusGranted;
     case CONTENT_SETTING_BLOCK:
@@ skipping 176 matching lines @@
       PlatformNotificationServiceImpl::GetInstance();
   // Can't use g_browser_process->notification_ui_manager(), since the test uses
   // PlatformNotificationServiceImpl::SetNotificationUIManagerForTesting.
   // TODO(peter): Remove the need to use both APIs here once Notification.get()
   // is supported.
   int notification_count = notification_service->GetNotificationUIManager()->
       GetAllIdsByProfileAndSourceOrigin(profile_, application_id.origin).size();
   if (notification_count > 0)
     return;
 
+  // Sites with a currently visible tab don't need to show notifications.
+#if defined(OS_ANDROID)
+  for (TabModel* tab_model : TabModelList) {
+    Profile* profile = tab_model->GetProfile();
+    content::WebContents* active_web_contents =
+        tab_model->GetActiveWebContents();
+#else
+  for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+    Profile* profile = it->profile();
+    content::WebContents* active_web_contents =
+        it->tab_strip_model()->GetActiveWebContents();
+#endif
+
+    // Don't leak information from other profiles.
+    if (!profile || profile->IsOffTheRecord() ||
+        !profile->IsSameProfile(profile_))
+      continue;
+
+    // Ignore minimized windows etc.
+    if (!active_web_contents || !IsWebContentsUserVisible(active_web_contents))
+      continue;
+
+    // Allow https://foo.example.com Service Worker to not show notification if
+    // an https://bar.example.com tab is visible (and hence might conceivably
+    // be showing UI in response to the push message); but http:// doesn't count
+    // as even with navigator.connect the Service Worker can't talk to it.

[Michael van Ouwerkerk, 2015/01/21 19:13:22]

Comment seems long.

[johnme, 2015/01/21 19:32:19]

What I'm doing here is a bit unusual: I'm requiring the scheme to match, but not
for security reasons. Hence the wordy explanation.

+    if (application_id.origin.scheme() !=
+        active_web_contents->GetVisibleURL().scheme())
+      continue;
+    if (net::registry_controlled_domains::SameDomainOrHost(
+        application_id.origin,
+        active_web_contents->GetVisibleURL(),

[Michael van Ouwerkerk, 2015/01/21 19:13:22]

Please document why GetLastCommittedUrl is the wrong thing here.

[johnme, 2015/01/21 19:32:19]

Done.

+        net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES))
+      return;
+  }
+
   // If we haven't returned yet, the site failed to show a notification, so we
   // will show a generic notification. See https://crbug.com/437277
   // TODO(johnme): The generic notification should probably automatically close
   // itself when the next push message arrives?
   content::PlatformNotificationData notification_data;
   // TODO(johnme): Switch to FormatOriginForDisplay from crbug.com/402698
   notification_data.title = l10n_util::GetStringFUTF16(
       IDS_PUSH_MESSAGING_GENERIC_NOTIFICATION_TITLE,
       base::UTF8ToUTF16(application_id.origin.host()));
   notification_data.direction =
@@ skipping 248 matching lines @@
 bool PushMessagingServiceImpl::HasPermission(const GURL& origin) {
   gcm::PushMessagingPermissionContext* permission_context =
       gcm::PushMessagingPermissionContextFactory::GetForProfile(profile_);
   DCHECK(permission_context);
 
   return permission_context->GetPermissionStatus(origin, origin) ==
       CONTENT_SETTING_ALLOW;
 }
 
 }  // namespace gcm