Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 866403006: Set class names for ime's view classes. (Closed)

Created:
5 years, 11 months ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org, yukishiino+watch_chromium.org, Shu Chen
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set class names for ime's view classes. BUG=450703 R=mukai@chromium.org Committed: https://crrev.com/653e98f8e47c5d525492d976e3780ec03bae8eae Cr-Commit-Position: refs/heads/master@{#313156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M ui/chromeos/ime/candidate_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_view.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/chromeos/ime/candidate_window_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/chromeos/ime/infolist_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/chromeos/ime/infolist_window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/chromeos/ime/mode_indicator_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/mode_indicator_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
oshima
I didn't define the static field as it wasn't necessary. Let me know if you ...
5 years, 11 months ago (2015-01-26 21:42:50 UTC) #1
Jun Mukai
lgtm
5 years, 11 months ago (2015-01-26 21:47:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866403006/1
5 years, 11 months ago (2015-01-26 21:55:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 22:42:46 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 22:43:38 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/653e98f8e47c5d525492d976e3780ec03bae8eae
Cr-Commit-Position: refs/heads/master@{#313156}

Powered by Google App Engine
This is Rietveld 408576698