Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 866373002: Reenable/rebaseline DumpAccessibilityTreeTest.AccessibilityANoText (Closed)

Created:
5 years, 11 months ago by kouhei (in TOK)
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable/rebaseline DumpAccessibilityTreeTest.AccessibilityANoText This CL reenables the disabled test: - DumpAccessibilityTreeTest.AccessibilityANoText. The test result is rebaselined so that it matches what spec says. The alttext for failed <img> load should show filename of the src. http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen BUG=448518, 421300 R=dmazzoni@chromium.org Committed: https://crrev.com/5ad886dd80d7ed7cf8cb7dedbcf9f56531d8c75a Cr-Commit-Position: refs/heads/master@{#313041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/a-no-text-expected-android.txt View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kouhei (in TOK)
Would you take a look? This is a follow up to https://codereview.chromium.org/673603002 .
5 years, 11 months ago (2015-01-23 05:47:09 UTC) #1
dmazzoni
lgtm
5 years, 11 months ago (2015-01-23 19:02:28 UTC) #2
kouhei (in TOK)
On 2015/01/23 19:02:28, dmazzoni wrote: > lgtm Thanks!
5 years, 11 months ago (2015-01-26 01:22:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866373002/1
5 years, 11 months ago (2015-01-26 01:22:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 02:18:24 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 02:19:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ad886dd80d7ed7cf8cb7dedbcf9f56531d8c75a
Cr-Commit-Position: refs/heads/master@{#313041}

Powered by Google App Engine
This is Rietveld 408576698