Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Issue 866283007: clang-format //shell and add a PRESUBMIT.py to keep it clang-formatted. (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

clang-format //shell and add a PRESUBMIT.py to keep it clang-formatted. (One day, once everything is clang-formatted, we'll just add that check to the root PRESUBMIT.py. Directories like //base remain problematic for now though.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/32952271830d417e7ae98b08aecc0f0760648a37

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove virtual when there's override. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -29 lines) Patch
A + shell/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/android/mojo_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/application_manager/application_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_manager.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 5 chunks +8 lines, -12 lines 0 comments Download
M shell/context.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M shell/dynamic_service_runner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M shell/out_of_process_dynamic_service_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
5 years, 10 months ago (2015-02-11 23:36:21 UTC) #1
jamesr
lgtm https://codereview.chromium.org/866283007/diff/1/shell/application_manager/application_manager_unittest.cc File shell/application_manager/application_manager_unittest.cc (right): https://codereview.chromium.org/866283007/diff/1/shell/application_manager/application_manager_unittest.cc#newcode415 shell/application_manager/application_manager_unittest.cc:415: virtual void OnApplicationError(const GURL& url) override {} while ...
5 years, 10 months ago (2015-02-11 23:44:48 UTC) #2
viettrungluu
https://codereview.chromium.org/866283007/diff/1/shell/application_manager/application_manager_unittest.cc File shell/application_manager/application_manager_unittest.cc (right): https://codereview.chromium.org/866283007/diff/1/shell/application_manager/application_manager_unittest.cc#newcode415 shell/application_manager/application_manager_unittest.cc:415: virtual void OnApplicationError(const GURL& url) override {} On 2015/02/11 ...
5 years, 10 months ago (2015-02-11 23:59:03 UTC) #4
viettrungluu
5 years, 10 months ago (2015-02-12 00:32:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
32952271830d417e7ae98b08aecc0f0760648a37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698