Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 866283003: Remove TouchDisambiguation and WindowFocusAllowedIndicator (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove TouchDisambiguation and WindowFocusAllowedIndicator TouchDisambiguation is dead code. WindowFocusAllowedIndicator doesn't make any sense because you're always allowed to focus. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bdf412b7ece6773edcfc4b0207876d660a80c53c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -301 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +1 line, -6 lines 0 comments Download
D sky/engine/core/page/TouchDisambiguation.h View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/engine/core/page/TouchDisambiguation.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D sky/engine/core/page/WindowFocusAllowedIndicator.h View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/engine/core/page/WindowFocusAllowedIndicator.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 11 months ago (2015-01-23 00:24:04 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-23 00:25:06 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-23 00:26:07 UTC) #5
abarth-chromium
5 years, 11 months ago (2015-01-23 02:25:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bdf412b7ece6773edcfc4b0207876d660a80c53c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698