Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: libvpx_srcs_x86_64_intrinsics.gypi

Issue 866273003: Use the correct AVX flags for Windows builds (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libvpx_srcs_x86_64_intrinsics.gypi
diff --git a/libvpx_srcs_x86_64_intrinsics.gypi b/libvpx_srcs_x86_64_intrinsics.gypi
index bd81bd9b03ea87d9d9131e4469e324eb73a5434d..a812e3aab8bf7171f28f74c512e0d0b0c361d4ad 100644
--- a/libvpx_srcs_x86_64_intrinsics.gypi
+++ b/libvpx_srcs_x86_64_intrinsics.gypi
@@ -66,7 +66,8 @@
'conditions': [
['OS=="win" and clang==1', {
# cl.exe's /arch flag doesn't have a setting for SSSE3/4, and cl.exe
- # doesn't need it for intrinsics. clang-cl does need it, though.
+ # doesn't need it for intrinsics. There is an /arch flag for AVX2 but
+ # clang-cl needs its own in the form of -mOPT.
'msvs_settings': {
'VCCLCompilerTool': { 'AdditionalOptions': [ '-mssse3' ] },
},
@@ -88,7 +89,8 @@
'conditions': [
['OS=="win" and clang==1', {
# cl.exe's /arch flag doesn't have a setting for SSSE3/4, and cl.exe
- # doesn't need it for intrinsics. clang-cl does need it, though.
+ # doesn't need it for intrinsics. There is an /arch flag for AVX2 but
+ # clang-cl needs its own in the form of -mOPT.
'msvs_settings': {
'VCCLCompilerTool': { 'AdditionalOptions': [ '-msse4.1' ] },
},
@@ -121,6 +123,16 @@
'EnableEnhancedInstructionSet': '3', # /arch:AVX
},
},
+ 'conditions': [
+ ['OS=="win" and clang==1', {
+ # cl.exe's /arch flag doesn't have a setting for SSSE3/4, and cl.exe
+ # doesn't need it for intrinsics. There is an /arch flag for AVX2 but
+ # clang-cl needs its own in the form of -mOPT.
+ 'msvs_settings': {
+ 'VCCLCompilerTool': { 'AdditionalOptions': [ '-mavx2' ] },
+ },
+ }],
+ ],
},
],
}
« generate_gypi.sh ('K') | « generate_gypi.sh ('k') | libvpx_srcs_x86_intrinsics.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698