chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc - Issue 866263008: MacViews: Unify web contents modal dialog types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

Issue 866263008: MacViews: Unify web contents modal dialog types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble

Patch Set: Another idea Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm ('K') | « chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc ('k') | components/web_modal/native_web_contents_modal_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

diff --git a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

index 1664dfac2d65ae9d199761d07913e07e3dd707eb..f2e6930d0fe41d8f0c260ab9f49937b0e2f1bb5a 100644

--- a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

+++ b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

@@ -220,7 +220,7 @@ class NativeWebContentsModalDialogManagerViews

#endif

// Will cause this object to be deleted.

- native_delegate_->WillClose(widget->GetNativeView());

+ native_delegate_->WillClose(widget->GetNativeWindow());

}

SingleWebContentsDialogManagerDelegate* native_delegate_;