chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc - Issue 866263008: MacViews: Unify web contents modal dialog types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Issue 866263008: MacViews: Unify web contents modal dialog types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble

Patch Set: Fix test crashes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm ('K') | « chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm ('k') | chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

diff --git a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

index 37b639138a4e61cc6e6d8e6c4e1bfd4a10b528a9..3b20f0e134dcfdce866e1af44f65b1cfff375c33 100644

--- a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

+++ b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

@@ -125,7 +125,7 @@ class ConstrainedWebDialogDelegateViews

// ConstrainedWebDialogDelegate:

web_modal::NativeWebContentsModalDialog GetNativeDialog() override {

- return view_->GetWidget()->GetNativeView();

+ return view_->GetWidget()->GetNativeWindow();

}

private:

@@ -246,7 +246,7 @@ class ConstrainedWebDialogDelegateViewViews

web_modal::PopupManager* popup_manager =

web_modal::PopupManager::FromWebContents(

initiator_observer_.web_contents());

- popup_manager->ShowModalDialog(GetWidget()->GetNativeView(),

+ popup_manager->ShowModalDialog(GetWidget()->GetNativeWindow(),

initiator_observer_.web_contents());

}