chrome/browser/ui/cocoa/certificate_viewer_mac.mm - Issue 866263008: MacViews: Unify web contents modal dialog types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/certificate_viewer_mac.mm

Issue 866263008: MacViews: Unify web contents modal dialog types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble

Patch Set: Fix test crashes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm » ('j') | chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/certificate_viewer_mac.mm

diff --git a/chrome/browser/ui/cocoa/certificate_viewer_mac.mm b/chrome/browser/ui/cocoa/certificate_viewer_mac.mm

index 02995b56f3655c0e479ce5c881daeb4f759b89e9..e5f6a9a13d975b2d4b9b6552de4c1ce32780d7ec 100644

--- a/chrome/browser/ui/cocoa/certificate_viewer_mac.mm

+++ b/chrome/browser/ui/cocoa/certificate_viewer_mac.mm

@@ -197,6 +197,10 @@ void ShowCertificateViewer(content::WebContents* web_contents,

// NOOP

}

+- (NSWindow*)sheetWindow {

+ return panel_;

- (void)onConstrainedWindowClosed {

panel_.reset();

constrainedWindow_.reset();