chrome/chrome_browser_ui.gypi - Issue 866263008: MacViews: Unify web contents modal dialog types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 866263008: MacViews: Unify web contents modal dialog types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble

Patch Set: Fix for rsesek Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('k') | components/web_modal/native_web_contents_modal_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index a1f98916df4771e0a8ec0959305473362831c01a..6dc4f5d61f05ad02bd5b82eaccb8a2f7aa5d4e36 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -652,6 +652,8 @@

'browser/ui/cocoa/screen_capture_notification_ui_cocoa.h',

'browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm',

'browser/ui/cocoa/simple_message_box_mac.mm',

+ 'browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.h',

+ 'browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm',

'browser/ui/cocoa/sprite_view.h',

'browser/ui/cocoa/sprite_view.mm',

'browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h',

@@ -732,7 +734,6 @@

'browser/ui/cocoa/view_id_util.h',

'browser/ui/cocoa/view_id_util.mm',

'browser/ui/cocoa/view_resizer.h',

- 'browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.mm',

'browser/ui/cocoa/web_dialog_window_controller.h',

'browser/ui/cocoa/web_dialog_window_controller.mm',

'browser/ui/cocoa/website_settings/permission_bubble_cocoa.h',