MacViews: Unify web contents modal dialog types

components/web_modal/native_web_contents_modal_dialog.h

Index: components/web_modal/native_web_contents_modal_dialog.h
diff --git a/components/web_modal/native_web_contents_modal_dialog.h b/components/web_modal/native_web_contents_modal_dialog.h
index 4bb956a8ef09010a78bb25d41b177dfa53f72c86..c0dfdb0ee7c2ca3ad12b8ddc9541a4ece2603b66 100644
--- a/components/web_modal/native_web_contents_modal_dialog.h
+++ b/components/web_modal/native_web_contents_modal_dialog.h
@@ -11,21 +11,8 @@ namespace web_modal {
 
 // TODO(gbillock): rename this file

[Robert Sesek, 2015/03/02 22:15:27]

It seems like this entire file could be removed and the gfx types could be use
instead.

[Andre, 2015/03/02 22:45:38]

There are quite a bit of call sites that will need to be adjusted.
I can do this replacement in a separate CL if wittman@ and msw@ approves.

[Mike Wittman, 2015/03/02 22:48:31]

Replacing types and removing this file in a separate CL sgtm.

[msw, 2015/03/02 23:07:02]

Ditto, I think that's a great suggestion.

 
-#if defined(OS_MACOSX)
-// Use a void* since none of the gfx::Native* types are suitable for
-// representing the web contents modal dialog under Cocoa.
-typedef void* NativeWebContentsModalDialog;
-#else
-typedef gfx::NativeView NativeWebContentsModalDialog;
-#endif
-
-#if defined(OS_MACOSX)
-// Use a void* since none of the gfx::Native* types are suitable for
-// representing a popup window under Cocoa.
-typedef void* NativePopup;
-#else
-typedef gfx::NativeView NativePopup;
-#endif
+typedef gfx::NativeWindow NativeWebContentsModalDialog;

[Robert Sesek, 2015/03/02 22:15:27]

|using| is now preferred.

[Andre, 2015/03/02 22:45:38]

Done.

+typedef gfx::NativeWindow NativePopup;
 
 }  // namespace web_modal