chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h - Issue 866263008: MacViews: Unify web contents modal dialog types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h

Issue 866263008: MacViews: Unify web contents modal dialog types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble

Patch Set: Refining and fixed tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm ('K') | « chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm ('k') | chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm » ('j') | chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h b/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h

index 2352af0c7288750407f06800673826492cdaed67..c158022fe62367170772ac9cefe8b4c168a867da 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h

@@ -24,6 +24,8 @@

- (void)updateSheetPosition;

+@property(readonly) NSWindow* sheetWindow;

tapted 2015/02/26 23:34:49 nonatomic?

Andre 2015/03/02 02:55:56 I wasn't sure what readonly+nonatomic means. I sup

@end

#endif // CHROME_BROWSER_UI_COCOA_CONSTRAINED_WINDOW_CONSTRAINED_WINDOW_SHEET_H_