MacViews: Unify web contents modal dialog types

chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_cocoa.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_WEB_CONTENTS_MODAL_DIALOG_MANAGER_COCOA_H_
+#define CHROME_BROWSER_UI_COCOA_WEB_CONTENTS_MODAL_DIALOG_MANAGER_COCOA_H_
+
+#include "base/mac/scoped_nsobject.h"

[tapted, 2015/02/26 23:34:49]

nit: import

[Andre, 2015/03/02 02:55:56]

Done.

+#include "base/observer_list.h"
+#include "components/web_modal/single_web_contents_dialog_manager.h"
+
+@protocol ConstrainedWindowSheet;
+
+class WebContentsModalDialogManagerCocoa

[tapted, 2015/02/26 23:34:49]

It's a mouthful, but perhaps prefix with 'Single'. As it is, I think this is a
bad name. It implies the class inherits from WebContentsModalDialogManager, but
that's who owns it. Also (nit): needs a class comment.

[Andre, 2015/03/02 02:55:56]

Done.

+    : public web_modal::SingleWebContentsDialogManager {
+ public:
+  WebContentsModalDialogManagerCocoa(
+      id<ConstrainedWindowSheet> sheet,
+      web_modal::SingleWebContentsDialogManagerDelegate* delegate);
+  ~WebContentsModalDialogManagerCocoa() override;
+
+  class Observer {
+   public:
+    virtual ~Observer() {}
+    virtual void OnDialogClosing() = 0;  // Called when the dialog is closing.
+  };
+
+  void AddObserver(Observer* observer);
+  void RemoveObserver(Observer* observer);
+
+  // SingleWebContentsDialogManager overrides.
+  void Show() override;
+  void Hide() override;
+  void Close() override;
+  void Focus() override;
+  void Pulse() override;
+  void HostChanged(web_modal::WebContentsModalDialogHost* new_host) override;
+  web_modal::NativeWebContentsModalDialog dialog() override;
+
+ private:
+  base::scoped_nsprotocol<id<ConstrainedWindowSheet>> sheet_;
+  // Weak. Owns this.
+  web_modal::SingleWebContentsDialogManagerDelegate* delegate_;
+  ObserverList<Observer> observers_;
+  bool shown_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebContentsModalDialogManagerCocoa);
+};
+
+#endif  // CHROME_BROWSER_UI_COCOA_WEB_CONTENTS_MODAL_DIALOG_MANAGER_COCOA_H_