Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 866263005: Remove version generation approach. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove version generation approach. Revert "Partially reland Auto-generate v8 version based on tags." This reverts commit 0707afc863e14ad216fa2157f41fc35f86bd64b2. Revert "Ensure tags are fetched when generating the V8 version." This reverts commit ea6831e9de62ceade14b7baeb7d57c74a30a1f38. Revert "Restrict tag-update for version generation to cached git repos." This reverts commit c6641e138bb4a81b47f70e62bb9113c87b590a6f. BUG=chromium:446166 LOG=n Committed: https://crrev.com/5577dbdcf13c2f6091c81bfee6a810aa51fa6778 Cr-Commit-Position: refs/heads/master@{#26244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -170 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M Makefile View 6 chunks +7 lines, -15 lines 0 comments Download
D build/generate_version.py View 1 chunk +0 lines, -149 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-23 10:04:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-23 10:06:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866263005/1
5 years, 11 months ago (2015-01-23 10:16:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 10:45:31 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 10:45:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5577dbdcf13c2f6091c81bfee6a810aa51fa6778
Cr-Commit-Position: refs/heads/master@{#26244}

Powered by Google App Engine
This is Rietveld 408576698