Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Issue 8662015: fix generic const canonicalization bug (Closed)

Created:
9 years, 1 month ago by jimhug
Modified:
9 years, 1 month ago
Reviewers:
ahe, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix generic const canonicalization bug, also needed to "fix" issue in resolveMember on generics as this exposed another generics issue. BUG=540 TEST=frogsh compile - once warnings are errors Committed: https://code.google.com/p/dart/source/detail?r=1807

Patch Set 1 #

Patch Set 2 : presubmit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -184 lines) Patch
M frog/frogsh View 1 52 chunks +212 lines, -167 lines 0 comments Download
M frog/gen.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M frog/leg/scanner/listener.dart View 1 chunk +1 line, -2 lines 0 comments Download
M frog/type.dart View 1 3 chunks +34 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jimhug
TBR
9 years, 1 month ago (2011-11-23 19:17:35 UTC) #1
Jennifer Messerly
lgtm. I think what we need to do here is move resolveMember to the base ...
9 years, 1 month ago (2011-11-23 19:25:59 UTC) #2
ahe
9 years, 1 month ago (2011-11-24 09:06:31 UTC) #3
Changes to listener.dart LGTM!

Powered by Google App Engine
This is Rietveld 408576698