Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 866183002: Roll Chrome into Mojo. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Roll Chrome into Mojo. This roll corresponds to: https://chromium.googlesource.com/chromium/src/+/ef1c46ab8a359ae309b49b3222c10bb2ef0bcf09 This updates the skia BUILD.gn files to keep them from pulling in pango and cairo when use_pango is false. BUG=442545 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1723cbdc08f4aea635edaccc48b7247956ad306b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -455 lines) Patch
M DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M base/timer/timer_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M build/all.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/arm.gni View 1 chunk +8 lines, -5 lines 0 comments Download
M build/get_syzygy_binaries.py View 2 chunks +8 lines, -1 line 0 comments Download
D build/secondary/third_party/openmax_dl/dl/BUILD.gn View 1 chunk +0 lines, -249 lines 0 comments Download
M cc/animation/layer_animation_controller.h View 4 chunks +14 lines, -4 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 2 chunks +67 lines, -12 lines 0 comments Download
M cc/animation/layer_animation_value_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/layer.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M cc/layers/layer_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 5 chunks +1 line, -12 lines 0 comments Download
M cc/test/animation_test_common.h View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/test/animation_test_common.cc View 2 chunks +1 line, -7 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -18 lines 0 comments Download
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 3 chunks +12 lines, -2 lines 0 comments Download
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 7 chunks +36 lines, -21 lines 0 comments Download
M testing/android/native_test_launcher.cc View 3 chunks +16 lines, -58 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 16 chunks +56 lines, -16 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +30 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Elliot Glaysher
First time I'm rolling. Things seemed to go smoothly...
5 years, 11 months ago (2015-01-22 22:30:46 UTC) #2
jamesr
lgtm
5 years, 11 months ago (2015-01-22 22:40:59 UTC) #3
Elliot Glaysher
Committed patchset #1 (id:1) manually as 1723cbdc08f4aea635edaccc48b7247956ad306b.
5 years, 11 months ago (2015-01-22 22:42:56 UTC) #4
jamesr
Btw, why didn't you use the commit message the script generated? It has an https://crrev.com/... ...
5 years, 11 months ago (2015-01-22 22:46:09 UTC) #5
Elliot Glaysher
On 2015/01/22 22:46:09, jamesr wrote: > Btw, why didn't you use the commit message the ...
5 years, 11 months ago (2015-01-22 22:55:39 UTC) #6
Elliot Glaysher
5 years, 11 months ago (2015-01-22 22:55:39 UTC) #7
Message was sent while issue was closed.
On 2015/01/22 22:46:09, jamesr wrote:
> Btw, why didn't you use the commit message the script generated?  It has an
> https://crrev.com/... URL which is much nicer than what you used.

I didn't see it generate one. I'll keep that in mind for next time.

Powered by Google App Engine
This is Rietveld 408576698