components/plugins/renderer/plugin_placeholder.h - Issue 866173002: Plugin Power Saver: Add UI Overlay to throttled plugin using placeholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/plugin_placeholder.h

Issue 866173002: Plugin Power Saver: Add UI Overlay to throttled plugin using placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/plugins/renderer/loadable_plugin_placeholder.cc ('K') | « components/plugins/renderer/loadable_plugin_placeholder.cc ('k') | content/public/renderer/plugin_instance_throttler.h » ('j') | content/renderer/pepper/plugin_instance_throttler_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/plugin_placeholder.h

diff --git a/components/plugins/renderer/plugin_placeholder.h b/components/plugins/renderer/plugin_placeholder.h

index b0f0f4cea02fc8a14913b228f809b8ec21647250..b3e47c754bf9d4e794bd9f0e4e2cc9888dbaab08 100644

--- a/components/plugins/renderer/plugin_placeholder.h

+++ b/components/plugins/renderer/plugin_placeholder.h

@@ -35,11 +35,11 @@ class PluginPlaceholder : public content::RenderFrameObserver,

blink::WebLocalFrame* GetFrame();

const blink::WebPluginParams& GetPluginParams() const;

- private:

// WebViewPlugin::Delegate methods:

void ShowContextMenu(const blink::WebMouseEvent&) override;

groby-ooo-7-16 2015/01/30 02:22:44 why do these need to be public now?

tommycli 2015/01/30 17:02:40 These are protected now because LoadablePluginPlac

void PluginDestroyed() override;

+ private:

// RenderFrameObserver methods:

void OnDestruct() override;