Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 866103002: Add native_display_delegate_proxy.cc to the list of files that can use AllowIO. (Closed)

Created:
5 years, 11 months ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, jam, spang
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NativeDisplayDelegateProxy needs to read a file which is necessary to start chrome on UI thread. The file is on tmpfs, so it should be fast. I've got jam@'s agreement, who is the owner of base/threading/thread_restriction*, in https://codereview.chromium.org/854203002/ BUG=None R=phajdan.jr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/756e484f8bc79091a8846a19b39ccc28f79e8d8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
oshima
5 years, 11 months ago (2015-01-22 20:46:48 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 11 months ago (2015-01-23 10:47:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/866103002/1
5 years, 11 months ago (2015-01-23 16:52:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37943)
5 years, 11 months ago (2015-01-23 16:59:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/756e484f8bc79091a8846a19b39ccc28f79e8d8d Cr-Commit-Position: refs/heads/master@{#312932}
5 years, 11 months ago (2015-01-23 21:32:30 UTC) #8
oshima
5 years, 11 months ago (2015-01-23 21:32:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
756e484f8bc79091a8846a19b39ccc28f79e8d8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698