LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js - Issue 866043005: [ServiceWorker] Tests for WindowClient.focus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

Issue 866043005: [ServiceWorker] Tests for WindowClient.focus(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_openwindow_tests

Patch Set: review comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-focus.js ('k') | LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

diff --git a/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js b/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

index bcc37391b4774d4e8cb5c4cfd26147149a76494e..b86a4e59e43a88f62f063889d1b0f8aec531ecc2 100644

--- a/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

+++ b/LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js

@@ -1,5 +1,5 @@

// This helper will setup a small test framework that will use TESTS and run

-// them iteratively and call self.postMessage('quit') when done.

+// them sequentially and call self.postMessage('quit') when done.

// This helper also exposes |client|, |postMessage()|, |runNextTestOrQuit()|,

// |synthesizeNotificationClick()| and |initialize()|.

importScripts('sw-test-helpers.js');

@@ -80,7 +80,7 @@ var TESTS = [

];

self.onmessage = function(e) {

- if (e.data == "start") {

+ if (e.data == 'start') {

initialize().then(runNextTestOrQuit);

} else {

initialize().then(function() {

@@ -88,4 +88,4 @@ self.onmessage = function(e) {

self.postMessage('quit');

});

}

+};