LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.html - Issue 866043005: [ServiceWorker] Tests for WindowClient.focus().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.html

Issue 866043005: [ServiceWorker] Tests for WindowClient.focus(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_openwindow_tests

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js » ('j') | LayoutTests/http/tests/serviceworker/chromium/resources/windowclient-focus.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Resource for WindowClient.focus() tests</title>

	5 </head>

	6 <body>

	7 <div>Foo</div>
	Michael van Ouwerkerk 2015/02/18 10:55:47 Omit this? Omit this? mlamouri (slow - plz ping) 2015/02/18 11:34:55 It's good for local debugging. You don't get a bla Show quoted text On 2015/02/18 at 10:55:47, Michael van Ouwerkerk wrote: > Omit this? It's good for local debugging. You don't get a blank iframe so you know you got something. mlamouri (slow - plz ping) 2015/02/18 11:34:55 It's good for local debugging. You don't get a bla Show quoted text On 2015/02/18 at 10:55:47, Michael van Ouwerkerk wrote: > Omit this? It's good for local debugging. You don't get a blank iframe so you know you got something. Michael van Ouwerkerk 2015/02/18 12:39:03 Ok, so then make it say something meaningful. In i Show quoted text On 2015/02/18 11:34:55, Mounir Lamouri wrote: > On 2015/02/18 at 10:55:47, Michael van Ouwerkerk wrote: > > Omit this? > > It's good for local debugging. You don't get a blank iframe so you know you got > something. Ok, so then make it say something meaningful. In its current state this only makes sense to you, and you've already asked 4 people to look at this.
	8 </body>

	9 <script>

	10 function insertFrame(name) {

	11 var frame = document.createElement('iframe');

	12 frame.src = 'windowclient-focus.html?' + name;

	13 document.body.appendChild(frame);

	14 }

	15

	16 if (location.search == "") {

	17 // If this window is the top level window, we should insert two iframes.

	18 // They shouldn't create new iframes.

	19 insertFrame("1");

	20 insertFrame("2");

	21 }

	22 </script>

	23 </html>

OLD	NEW