Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 866005: Describe PMBR in terms of syslinux GPT extension. (Closed)

Created:
10 years, 9 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
tedbo
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Describe PMBR in terms of syslinux GPT extension. syslinux provides a GPT-aware MBR that interprets the MBR content like this: Offset Size Contents -------------------------------------------------- 0x000/0 424 PMBR boot code 0x1a8/424 16 GUID of the boot partition 0x1b8/440 4 MBR-compatible disk ID 0x1bc/444 2 Magic number: 1D 9A 0x1be/446 16 PMBR protective entry 0x1ce/462 48 PMBR null entries 0x1fe/510 2 Boot signature: 55 AA This change modifies the gpt program to understand that format: 1) Expect no more than 424 bytes of executable code for the 'boot' command. 2) Display the boot partition GUID when the PMBR has the magic numbers 1D 9A at offset 0x1bc for the 'show' command.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M boot.c View 1 chunk +2 lines, -1 line 0 comments Download
M gpt.h View 1 chunk +5 lines, -1 line 1 comment Download
M show.c View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Richardson
10 years, 9 months ago (2010-03-11 22:16:23 UTC) #1
tedbo
10 years, 9 months ago (2010-03-12 22:32:47 UTC) #2
LGTM

Thanks! A minor request for comment below but this change looks very nice.

http://codereview.chromium.org/866005/diff/1/3
File gpt.h (right):

http://codereview.chromium.org/866005/diff/1/3#newcode60
gpt.h:60: struct mbr {
The original struct represented a generic MBR with up to 446 byes of code data.
The new struct is specific to the syslinux GPT new protocol (as was the code to
make it bootable in boot.c). Maybe add a comment here that explains that this is
specific to the Syslinux GTP MBR boot protocol?

Powered by Google App Engine
This is Rietveld 408576698