Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 865973006: Subzero: Make thread_local work under MacOS 10.6. (Closed)

Created:
5 years, 11 months ago by Jim Stichnoth
Modified:
5 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Make thread_local work under MacOS 10.6. MacOS doesn't support the thread_local keyword until 10.7 or later, and our bots run 10.6. Who knows whether Visual Studio supports it yet. In the meantime, use the old-style syntax. BUG= https://codereview.chromium.org/873443004/ R=jfb@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7d53825caab0e81c653de52833260dbe81963875

Patch Set 1 #

Total comments: 2

Patch Set 2 : ATTRIBUTE_TLS --> ICE_ATTRIBUTE_TLS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/IceCfg.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceDefs.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/IceGlobalContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceGlobalContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 11 months ago (2015-01-23 18:07:38 UTC) #2
JF
lgtm otherwise https://codereview.chromium.org/865973006/diff/1/src/IceDefs.h File src/IceDefs.h (right): https://codereview.chromium.org/865973006/diff/1/src/IceDefs.h#newcode48 src/IceDefs.h:48: #endif // !_MSC_VER SUBZERO_ATTRIBUTE_TLS
5 years, 11 months ago (2015-01-23 18:17:55 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/865973006/diff/1/src/IceDefs.h File src/IceDefs.h (right): https://codereview.chromium.org/865973006/diff/1/src/IceDefs.h#newcode48 src/IceDefs.h:48: #endif // !_MSC_VER On 2015/01/23 18:17:55, JF wrote: > ...
5 years, 11 months ago (2015-01-23 18:22:30 UTC) #4
Jim Stichnoth
5 years, 11 months ago (2015-01-23 18:22:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d53825caab0e81c653de52833260dbe81963875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698