Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 865973003: Update {virtual,override,final} to follow C++11 style in components, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
blundell
CC:
cbentzel+watch_chromium.org, chirantan+watch_chromium.org, chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in components, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd Cr-Commit-Position: refs/heads/master@{#312855}

Patch Set 1 #

Patch Set 2 : Fix format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -250 lines) Patch
M components/crash/app/breakpad_linux.cc View 1 1 chunk +15 lines, -15 lines 0 comments Download
M components/metrics/net/wifi_access_point_info_provider_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.h View 1 2 chunks +35 lines, -43 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 1 2 chunks +25 lines, -31 lines 0 comments Download
M components/pairing/fake_controller_pairing_controller.h View 1 3 chunks +20 lines, -21 lines 0 comments Download
M components/pairing/fake_host_pairing_controller.h View 1 2 chunks +17 lines, -18 lines 0 comments Download
M components/pairing/shark_connection_listener.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M components/policy/core/common/proxy_policy_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/policy/core/common/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_chromeos.h View 1 1 chunk +18 lines, -22 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
M components/timers/rtc_alarm.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 1 chunk +57 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:29:22 UTC) #2
blundell
lgtm
5 years, 11 months ago (2015-01-23 10:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865973003/20001
5 years, 11 months ago (2015-01-23 15:20:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 16:02:16 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 16:03:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd5bd4f4972ec164aa7811fb4bbc8fcc116168dd
Cr-Commit-Position: refs/heads/master@{#312855}

Powered by Google App Engine
This is Rietveld 408576698