platform_tools/android/bin/android_gdb_native - Issue 865943007: Cleanup the android scripts.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: platform_tools/android/bin/android_gdb_native

Issue 865943007: Cleanup the android scripts. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 #	2 #

3 # android_gdb: Pushes gdbserver. Connects and enters debugging environment.	3 # android_gdb_native: Pushes gdbserver, connects to specified Skia app,

	4 # and enters command line debugging environment.

4	5

5 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"	6 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

6 source $SCRIPT_DIR/android_setup.sh	7 source $SCRIPT_DIR/android_setup.sh

7	8

8 # setup the gdbserver	9 # setup the gdbserver

9 export BUILDTYPE # from android_setup.sh	10 export BUILDTYPE # from android_setup.sh

10 $SCRIPT_DIR/android_gdbserver -d ${DEVICE_ID} ${APP_ARGS[@]}	11 $SCRIPT_DIR/android_gdbserver -d ${DEVICE_ID} ${APP_ARGS[@]}

11	12

12 # quit if gdbserver setup failed	13 # quit if gdbserver setup failed

13 if [[ "$?" != "0" ]]; then	14 if [[ "$?" != "0" ]]; then

(...skipping 28 matching lines...) Expand all Loading...
42 } > $GDBSETUP	43 } > $GDBSETUP

43	44

44	45

45 # Launch gdb client	46 # Launch gdb client

46 echo "Entering gdb client shell"	47 echo "Entering gdb client shell"

47 GDB_COMMAND=$(command ls "$ANDROID_TOOLCHAIN"/*-gdb \| head -n1)	48 GDB_COMMAND=$(command ls "$ANDROID_TOOLCHAIN"/*-gdb \| head -n1)

48 "$GDB_COMMAND" -x $GDBSETUP	49 "$GDB_COMMAND" -x $GDBSETUP

49	50

50 # Clean up	51 # Clean up

51 rm -rf $GDB_TMP_DIR	52 rm -rf $GDB_TMP_DIR

OLD	NEW