Chromium Code Reviews Chromium Code Reviews
Issue 865943002:
Update SSL/malware/net error interstitial design (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/renderer/resources/neterror.html |
| diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html |
| index b9383646c283935de0f2f8b92f2f473eb81f3f14..32968092b588ed9be366d3caa658f532406eb7bc 100644 |
| --- a/chrome/renderer/resources/neterror.html |
| +++ b/chrome/renderer/resources/neterror.html |
| @@ -1,5 +1,5 @@ |
| <!doctype html> |
| -<html i18n-values="dir:textdirection;.style.fontSize:fontsize"> |
| +<html i18n-values="dir:textdirection"> |
| <head> |
| <meta charset="utf-8"> |
| <meta name="viewport" content="width=device-width, initial-scale=1.0, |
| @@ -7,40 +7,42 @@ |
| <title i18n-content="title"></title> |
| <link rel="stylesheet" href="../../browser/resources/security_warnings/interstitial_v2.css"> |
| <link rel="stylesheet" href="neterror.css"> |
| + <script src="../../browser/resources/security_warnings/interstitial_v2_mobile.js"></script> |
| <script src="neterror.js"></script> |
| <script src="offline.js"></script> |
| </head> |
| -<body id="t" i18n-values=".style.fontFamily:fontfamily"> |
| +<body id="t" i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> |
| <div id="main-frame-error" class="interstitial-wrapper"> |
| - <img class="icon" |
| - jseval="updateIconClass(this.classList, iconClass)"> |
| - <div id="main-message"> |
| - <h1 i18n-content="heading"></h1> |
| - <p hidden></p> |
| - <div id="buttons" class="nav-wrapper"> |
| - <div id="control-buttons" hidden> |
| - <button id="reload-button" |
| - class="blue-button text-button" |
| - onclick="trackClick(this.trackingId); |
| - reloadButtonClick(this.url);" |
| - jsselect="reloadButton" |
| - jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId" |
| - jscontent="msg"></button> |
| - <button id="stale-load-button" |
| - class="blue-button text-button" |
| - onclick="loadStaleButtonClick()" |
| - jsselect="staleLoadButton" |
| - jscontent="msg" jsvalues="title:title"></button> |
| - </div> |
| - <button id="details-button" class="text-button small-link" |
| - onclick="detailsButtonClick(); toggleHelpBox()" |
| - jsdisplay="details" jscontent="details" |
| - jsvalues=".detailsText:details; .hideDetailsText:hideDetails;"> |
| + <div id="main-content"> |
| + <img class="icon" |
| + jseval="updateIconClass(this.classList, iconClass)"> |
| + <div id="main-message"> |
| + <h1 i18n-content="heading"></h1> |
| + <p hidden></p> |
| + </div> |
| + </div> |
| + <div id="buttons" class="nav-wrapper"> |
| + <div id="control-buttons" hidden> |
| + <button id="reload-button" |
| + class="blue-button text-button" |
| + onclick="trackClick(this.trackingId); |
| + reloadButtonClick(this.url);" |
| + jsselect="reloadButton" |
| + jsvalues=".url:reloadUrl; .trackingId:reloadTrackingId" |
| + jscontent="msg"></button> |
| + <button id="stale-load-button" |
| + class="blue-button text-button" |
| + onclick="loadStaleButtonClick()" |
| + jsselect="staleLoadButton" |
| + jscontent="msg" jsvalues="title:title"></button> |
| </div> |
| + <button id="details-button" class="text-button small-link" |
| + onclick="detailsButtonClick(); toggleHelpBox()" |
| + jsdisplay="details" jscontent="details" |
| + jsvalues=".detailsText:details; .hideDetailsText:hideDetails;"></button> |
| </div> |
| - <!-- Outer and inner divs are needed both for margins and sizing. --> |
| - <div id="help-box-outer" class="hidden"> |
| - <div id="details"> |
| + <div id="details" class="hidden"> |
| + <!-- <div id="details"> --> |
|
arv (Not doing code reviews)
2015/01/23 22:13:13
Please clean this up before landing.
edwardjung
2015/01/26 10:55:38
Done.
|
| <div jsselect="summary"> |
| <span jsvalues=".innerHTML:msg"></span> |
| </div> |
| @@ -66,7 +68,7 @@ |
| </div> |
| </form> |
| <div class="error-code" jscontent="errorCode"></div> |
| - </div> |
| + <!-- </div> --> |
| </div> |
| </div> |
| <div id="sub-frame-error"> |
