Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 865853005: Roll opus to opus-HEAD-66611f1. (Closed)

Created:
5 years, 10 months ago by wtc
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll opus to opus-HEAD-66611f1. The third_party/opus/src CL is https://codereview.chromium.org/882843002. Support MIPS optimizations in opus. R=henrika@chromium.org,sergeyu@chromium.org BUG=452984 Committed: https://crrev.com/ebbf54dafa1be134a4d45fc30c103388dfaa8ff0 Cr-Commit-Position: refs/heads/master@{#313646}

Patch Set 1 #

Patch Set 2 : Turn off MIPS optimizations because they don't compile. #

Patch Set 3 : Use commitdiff git URL. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 1 2 chunks +31 lines, -1 line 3 comments Download
M third_party/opus/README.chromium View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/opus/opus.gyp View 1 3 chunks +18 lines, -1 line 0 comments Download
A third_party/opus/opus_srcs_mips.gypi View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
wtc
https://codereview.chromium.org/865853005/diff/40001/third_party/opus/BUILD.gn File third_party/opus/BUILD.gn (right): https://codereview.chromium.org/865853005/diff/40001/third_party/opus/BUILD.gn#newcode12 third_party/opus/BUILD.gn:12: cpu_arch == "arm" || cpu_arch == "arm64" || cpu_arch ...
5 years, 10 months ago (2015-01-29 00:39:25 UTC) #1
Sergey Ulanov
lgtm
5 years, 10 months ago (2015-01-29 01:15:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865853005/40001
5 years, 10 months ago (2015-01-29 01:29:35 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 01:33:26 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ebbf54dafa1be134a4d45fc30c103388dfaa8ff0 Cr-Commit-Position: refs/heads/master@{#313646}
5 years, 10 months ago (2015-01-29 01:34:34 UTC) #6
henrika (OOO until Aug 14)
5 years, 10 months ago (2015-02-03 09:19:51 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/899623002/ by henrika@chromium.org.

The reason for reverting is: This CL breaks WebRTC in Chrome since the new Opus
version is not bit-exact with the previous version..

Powered by Google App Engine
This is Rietveld 408576698