Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 865833002: Add missing BailoutId and FrameState to with statements. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing BailoutId and FrameState to with statements. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-450642 BUG=chromium:450642 LOG=N Committed: https://crrev.com/558efe21f0a029dcb9ace1ec15af62c420cd42e5 Cr-Commit-Position: refs/heads/master@{#26218}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M src/ast.h View 1 chunk +17 lines, -4 lines 1 comment Download
M src/ast-numbering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-450642.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-22 10:32:33 UTC) #1
Benedikt Meurer
LGTM https://codereview.chromium.org/865833002/diff/1/src/ast.h File src/ast.h (right): https://codereview.chromium.org/865833002/diff/1/src/ast.h#newcode1105 src/ast.h:1105: void set_base_id(int id) { base_id_ = id; } ...
5 years, 11 months ago (2015-01-22 10:35:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865833002/1
5 years, 11 months ago (2015-01-22 10:47:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/132)
5 years, 11 months ago (2015-01-22 10:49:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865833002/1
5 years, 11 months ago (2015-01-22 10:51:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 10:57:37 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 10:57:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/558efe21f0a029dcb9ace1ec15af62c420cd42e5
Cr-Commit-Position: refs/heads/master@{#26218}

Powered by Google App Engine
This is Rietveld 408576698