Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 865813005: Fix network portal detector crash on shutdown (Closed)

Created:
5 years, 11 months ago by stevenjb
Modified:
5 years, 11 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix network portal detector crash on shutdown Note: This doesn't occur under normal circumstances, but if a DBus crash (or something else) causes an immediate shutdown, we sometimes crash in NetworkPortalDetector::Get() which obscures the actual problem. This also updates the portal detector logging to use device_event_log.h. BUG=none Committed: https://crrev.com/dacf4ec47dcb83a6eae892bb2f1b104d62d05782 Cr-Commit-Position: refs/heads/master@{#312900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -40 lines) Patch
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 10 chunks +25 lines, -34 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_event_router_chromeos.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
5 years, 11 months ago (2015-01-22 18:25:03 UTC) #2
ygorshenin1
lgtm
5 years, 11 months ago (2015-01-23 15:07:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865813005/1
5 years, 11 months ago (2015-01-23 18:15:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 19:43:57 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 19:46:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dacf4ec47dcb83a6eae892bb2f1b104d62d05782
Cr-Commit-Position: refs/heads/master@{#312900}

Powered by Google App Engine
This is Rietveld 408576698