Replace "enable-encrypted-media" flag with "disable-encrypted-media".

Replace "enable-encrypted-media" flag with "disable-encrypted-media".

Invert the logic now that unprefixed EME APIs are enabled by default.

BUG=394918
TEST=Encrypted Media browser tests pass.

Committed: https://crrev.com/73bdb0b48f53c787e48e14637a32de22b8601bb3
Cr-Commit-Position: refs/heads/master@{#313162}

[ddorwin, 2015-01-22 22:12:08]

Patchset #1 (id:1) has been deleted

[ddorwin, 2015-01-22 22:12:55]

ddorwin@chromium.org changed reviewers:
+ xhwang@chromium.org

[ddorwin, 2015-01-22 22:12:55]

ddorwin@chromium.org changed required reviewers:
+ xhwang@chromium.org

[ddorwin, 2015-01-22 22:12:56]

https://codereview.chromium.org/870713002/ must be landed and rolled before this
can land.

[xhwang, 2015-01-22 22:25:42]

lgtm % nits

https://codereview.chromium.org/865793003/diff/20001/chrome/browser/media/enc...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/865793003/diff/20001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_browsertest.cc:340: // TODO(jrummell):
Merge into ECKEncryptedMediaTest once prefixed is removed.
What do we need to merge? When prefixed test is removed, shall we just remove
this class?

https://codereview.chromium.org/865793003/diff/20001/mojo/services/html_viewe...
File mojo/services/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/865793003/diff/20001/mojo/services/html_viewe...
mojo/services/html_viewer/html_viewer.cc:55: // Enables support for Encrypted
Media Extensions (e.g. MediaKeys).
update this comment

[ddorwin, 2015-01-22 22:37:20]

https://codereview.chromium.org/865793003/diff/20001/chrome/browser/media/enc...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/865793003/diff/20001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_browsertest.cc:340: // TODO(jrummell):
Merge into ECKEncryptedMediaTest once prefixed is removed.
On 2015/01/22 22:25:42, xhwang wrote:
> What do we need to merge? When prefixed test is removed, shall we just remove
> this class?

When we disable prefixed by default, we'll need to have a Prefixed class that
enables prefixed. Once it's removed, we'll only have ECKEncryptedMediaTest.

What probably needs to happen is that we create a Prefixed class and make
unprefixed the default. We also need to run more tests on unprefixed. To keep
this CL simple and focused, I'd like to do that in a separate CL. We can remove
or update this TODO in that CL.

I updated the comment. WDYT?

https://codereview.chromium.org/865793003/diff/20001/mojo/services/html_viewe...
File mojo/services/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/865793003/diff/20001/mojo/services/html_viewe...
mojo/services/html_viewer/html_viewer.cc:55: // Enables support for Encrypted
Media Extensions (e.g. MediaKeys).
On 2015/01/22 22:25:42, xhwang wrote:
> update this comment

Done.

[xhwang, 2015-01-22 22:46:20]

lgtm++

https://codereview.chromium.org/865793003/diff/20001/chrome/browser/media/enc...
File chrome/browser/media/encrypted_media_browsertest.cc (right):

https://codereview.chromium.org/865793003/diff/20001/chrome/browser/media/enc...
chrome/browser/media/encrypted_media_browsertest.cc:340: // TODO(jrummell):
Merge into ECKEncryptedMediaTest once prefixed is removed.
On 2015/01/22 22:37:20, ddorwin wrote:
> On 2015/01/22 22:25:42, xhwang wrote:
> > What do we need to merge? When prefixed test is removed, shall we just
remove
> > this class?
> 
> When we disable prefixed by default, we'll need to have a Prefixed class that
> enables prefixed. Once it's removed, we'll only have ECKEncryptedMediaTest.
> 
> What probably needs to happen is that we create a Prefixed class and make
> unprefixed the default. We also need to run more tests on unprefixed. To keep
> this CL simple and focused, I'd like to do that in a separate CL. We can
remove
> or update this TODO in that CL.
> 
> I updated the comment. WDYT?

I see. I forgot we need to put the prefixed API behind a flag before we remove
it. The new comment lg. Thanks!

[ddorwin, 2015-01-22 23:00:31]

ddorwin@chromium.org changed reviewers:
+ aa@chromium.org, jochen@chromium.org

[ddorwin, 2015-01-22 23:00:31]

ddorwin@chromium.org changed required reviewers:
+ aa@chromium.org, jochen@chromium.org

[ddorwin, 2015-01-22 23:00:31]

jochen: Please OWNERS review content/ and
chrome/browser/chromeos/login/chrome_restart_request.cc
aa: Please OWNERS revew mojo/services/html_viewer/html_viewer.cc

[jochen (gone - plz use gerrit), 2015-01-23 14:19:08]

jochen@chromium.org changed required reviewers:
- aa@chromium.org, jochen@chromium.org, xhwang@chromium.org

[jochen (gone - plz use gerrit), 2015-01-23 14:19:09]

lgtm

[ddorwin, 2015-01-23 22:15:10]

ddorwin@chromium.org changed reviewers:
+ isherman@chromium.org

[ddorwin, 2015-01-23 22:15:10]

aa@chromium.org: Please OWNERS review the small change in
mojo/services/html_viewer/html_viewer.cc

isherman@chromium.org: Please OWNERS review the rename in
tools/metrics/histograms/histograms.xml

[Ilya Sherman, 2015-01-23 23:09:26]

histograms.xml LGTM with my comment addressed:

https://codereview.chromium.org/865793003/diff/80001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/865793003/diff/80001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:50598: -  <int value="1668611601"
label="enable-encrypted-media"/>
Please preserve the original flag as well, so that old data remains viewable.

[ddorwin, 2015-01-23 23:28:42]

https://codereview.chromium.org/865793003/diff/80001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/865793003/diff/80001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:50598: -  <int value="1668611601"
label="enable-encrypted-media"/>
On 2015/01/23 23:09:26, Ilya Sherman wrote:
> Please preserve the original flag as well, so that old data remains viewable.

Done.

[Aaron Boodman, 2015-01-26 22:07:09]

lgtm

[ddorwin, 2015-01-26 22:07:43]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2015-01-26 22:09:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/865793003/100001

[commit-bot: I haz the power, 2015-01-26 23:03:55]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-01-26 23:04:49]

Patchset 5 (id:??) landed as
https://crrev.com/73bdb0b48f53c787e48e14637a32de22b8601bb3
Cr-Commit-Position: refs/heads/master@{#313162}