Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 865753002: Fix wrong capacity calculation for m_eventPath (Closed)

Created:
5 years, 11 months ago by kojii
Modified:
5 years, 11 months ago
Reviewers:
hayato, brucedawson
CC:
blink-reviews, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix wrong capacity calculation for m_eventPath https://codereview.chromium.org/849783002/ has a bug in the calculation of |reserveCapacity|, resulting unnecessary realloc, thanks to brucedawson for pointing this out. BUG=442632, 427616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/events/TreeScopeEventContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kojii
PTAL!
5 years, 11 months ago (2015-01-22 03:44:26 UTC) #2
hayato
lgtm
5 years, 11 months ago (2015-01-22 03:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865753002/1
5 years, 11 months ago (2015-01-22 03:49:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188787
5 years, 11 months ago (2015-01-22 03:52:40 UTC) #6
brucedawson
5 years, 11 months ago (2015-01-22 17:35:54 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698