Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 865713004: X87: Retry "Use a WeakCell in the CallIC type vector." (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Retry "Use a WeakCell in the CallIC type vector." port 6fc97a19653e03a891d3cd397069d5a10b9ab325 (r26420) original commit message: Retry "Use a WeakCell in the CallIC type vector." The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/7280426acb487564f61eb3716b7f2fb5989a8b9a Cr-Commit-Position: refs/heads/master@{#26517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M src/x87/code-stubs-x87.cc View 4 chunks +33 lines, -11 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 09:22:42 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 09:27:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865713004/1
5 years, 10 months ago (2015-02-09 09:28:38 UTC) #5
chunyang.dai
Committed patchset #1 (id:1) manually as 7280426acb487564f61eb3716b7f2fb5989a8b9a (presubmit successful).
5 years, 10 months ago (2015-02-09 09:30:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 09:30:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7280426acb487564f61eb3716b7f2fb5989a8b9a
Cr-Commit-Position: refs/heads/master@{#26517}

Powered by Google App Engine
This is Rietveld 408576698