tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py - Issue 865653004: Document and test that image_util.WritePngFile requires path end in 'png'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py

Issue 865653004: Document and test that image_util.WritePngFile requires path end in 'png'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review feedback from sullivan. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/image_processing/image_util.py ('k') | tools/telemetry/telemetry/image_processing/image_util_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py

diff --git a/tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py b/tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py

index 6fa07d5022ecfeb42987774908e4ef121ad0f5c0..538909668d71cc485689351903c2755dea782bef 100644

--- a/tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py

+++ b/tools/telemetry/telemetry/image_processing/image_util_numpy_impl.py

@@ -33,7 +33,6 @@ def GetPixelColor(image, x, y):

return rgba_color.RgbaColor(bgr[2], bgr[1], bgr[0])

def WritePngFile(image, path):

- assert(path.endswith('png'))

if cv2 is not None:

cv2.imwrite(path, image)

else: