Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issue 865613002: Reduce duplicated code in AwWebContentsDelegate (Closed)

Created:
5 years, 11 months ago by Hugo Holgersson
Modified:
5 years, 11 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce duplicated code in AwWebContentsDelegate This is pure refactoring. Functionality should not be affected. CL reduces duplicated code that AwWebContentsDelegate copied from WebContentsDelegateAndroid. Background: This cleanup is a first step towards moving the responsibility of ContentVideoView from the content embedders to the content-layer. The goal is to let WebContentsDelegateAndroid's ExitFullscreenModeForTab do the work that is common to both WebViews and Android Chrome; for example, tearing down ContentVideoView when fullscreen exits. BUG=449152 Committed: https://crrev.com/4f1b4544ed3786cd8c09c2620568d0d9e508f2ba Cr-Commit-Position: refs/heads/master@{#312590}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Missed one line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 1 chunk +5 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Hugo Holgersson
Background is found in https://codereview.chromium.org/845193005/ . PTAL
5 years, 11 months ago (2015-01-21 14:01:11 UTC) #2
Ignacio Solla
https://codereview.chromium.org/865613002/diff/1/android_webview/native/aw_web_contents_delegate.cc File android_webview/native/aw_web_contents_delegate.cc (right): https://codereview.chromium.org/865613002/diff/1/android_webview/native/aw_web_contents_delegate.cc#newcode221 android_webview/native/aw_web_contents_delegate.cc:221: WebContentsDelegateAndroid::ExitFullscreenModeForTab(web_contents); aren't you misssing the call to web_contents->GetRenderViewHost()->WasResized(); here?
5 years, 11 months ago (2015-01-21 14:23:04 UTC) #3
Hugo Holgersson
https://codereview.chromium.org/865613002/diff/1/android_webview/native/aw_web_contents_delegate.cc File android_webview/native/aw_web_contents_delegate.cc (right): https://codereview.chromium.org/865613002/diff/1/android_webview/native/aw_web_contents_delegate.cc#newcode221 android_webview/native/aw_web_contents_delegate.cc:221: WebContentsDelegateAndroid::ExitFullscreenModeForTab(web_contents); On 2015/01/21 14:23:04, Ignacio Solla wrote: > aren't ...
5 years, 11 months ago (2015-01-21 14:26:44 UTC) #4
Ignacio Solla
lgtm
5 years, 11 months ago (2015-01-21 14:27:42 UTC) #5
Hugo Holgersson
On 2015/01/21 14:27:42, Ignacio Solla wrote: > lgtm @mkosiba, PTAL
5 years, 11 months ago (2015-01-21 14:35:33 UTC) #6
mkosiba (inactive)
On 2015/01/21 14:35:33, Hugo Holgersson wrote: > On 2015/01/21 14:27:42, Ignacio Solla wrote: > > ...
5 years, 11 months ago (2015-01-21 14:59:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865613002/20001
5 years, 11 months ago (2015-01-21 15:11:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/34792)
5 years, 11 months ago (2015-01-21 15:42:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865613002/20001
5 years, 11 months ago (2015-01-21 16:15:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/34788)
5 years, 11 months ago (2015-01-21 16:16:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865613002/20001
5 years, 11 months ago (2015-01-22 08:46:45 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 08:47:47 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 08:48:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f1b4544ed3786cd8c09c2620568d0d9e508f2ba
Cr-Commit-Position: refs/heads/master@{#312590}

Powered by Google App Engine
This is Rietveld 408576698